update of oslc4j bundles to match changes to Lyo Core.

eclipse / lyo.designer

lyo.designer

Eclipse Public License 2.0

11 stars 10 forks source link

update of oslc4j bundles to match changes to Lyo Core. #262

Closed Jad-el-khoury closed 1 year ago

Jad-el-khoury commented 1 year ago

update of oslc4j bundles to match changes to Lyo Core.

Checklist

[ ] This PR adds an entry to the CHANGELOG. _See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
[ ] This PR expects some manual changes to the generated code. The needed changes are detailed in the CHANGELOG entry.
[X] This PR was tested with at least one code generation, resulting in a working OSLC server.
[X] This PR does NOT break the user block code

berezovskyi commented 1 year ago

Don't ever recall using com.google.code.gson anywhere, and I imagine the Apache HTTP deps removal is motivated by using the P2-provided versions instead?

jadelkhoury commented 1 year ago

Don't ever recall using com.google.code.gson anywhere, and I imagine the Apache HTTP deps removal is motivated by using the P2-provided versions instead?

just copied what we did for the core plugin (See line 134). I believe we do use gson. and indeed, we had trouble when we included the apache libraries and overidded the ones Eclipse already had. Maybe unecessary, but I thought it safer to have the same on all parts.