search

eclipse / microprofile-config

MicroProfile Configuration Feature
Apache License 2.0
211 stars 115 forks source link

[Fix 777] Add javax.inject.Qualifier to allow integration with Guice. #778

Closed scr-oath closed 1 year ago

scr-oath commented 1 year ago

Add @javax.inject.Qualifier to @ConfigProperty in order to allow integration with Guice; make the dependency optional so that the dependency is not transitive.

eclipse-microprofile-bot commented 1 year ago

Can one of the admins verify this patch?

dmlloyd commented 1 year ago

The problem here is introducing cross-dependencies between MicroProfile and Jakarta EE (actually Java EE in this case). I for one don't think this should go in as-is, until/unless the relationship between MicroProfile and Java/Jakarta EE is worked out; it might be up to each vendor to configure this as needed using manual means in the meantime.

Emily-Jiang commented 1 year ago

All MicroProfile specs have updated from javax to jakarta. If you want to use javax namespace, you should use the previous version of MicroProfile specs. For config, it will be version 2.x or earlier.

Emily-Jiang commented 1 year ago

@scr-oath in light of the above conversation, I am going to close this PR by the end of this week if there is no more update on this. By the way, if you want to contribute to Eclipse projects, you will need to sign a ECA as mentioned in the above check failures above.

Emily-Jiang commented 1 year ago

close this PR as per the above comment. Please reopen if you think we need to discuss more on this.