search

eclipse / microprofile-context-propagation

Apache License 2.0
34 stars 23 forks source link

clarify ThreadContext propagation for *Async methods that are supplied with a different executor #111

Closed njr-11 closed 5 years ago

njr-11 commented 5 years ago

pull fixes #110

Signed-off-by: Nathan Rauh nathan.rauh@us.ibm.com

njr-11 commented 5 years ago

updated to reflect the majority view and also to include the detail about pre-contextualized actions taking precedence, which had previously been lacking from the JavaDoc

njr-11 commented 5 years ago

I haven't seen any further feedback and so given that the outcome is now 4 to 2 in favor of the proposal to use the thread context propagation of the ManagedExecutor which is the default asynchronous execution for the stage rather than override it when the supplied executor is also a ManagedExecutor, let's go with the preference of the majority on this. This pull is updated accordingly. @FroMage or @manovotn could you review it? I'll also look into getting a TCK scenario added for this, but as a separate pull.