search

eclipse / microprofile-context-propagation

Apache License 2.0
34 stars 23 forks source link

mark transaction for rollback only after rejection of parallel use #157

Closed njr-11 closed 5 years ago

njr-11 commented 5 years ago

pull fixes #156

njr-11 commented 5 years ago

Changes look good but was there a particular reason why the tests don't always call rollback for the finally step.

No reason that I know of. It would certainly be valid to do that, and a bit simpler because we wouldn't need it to track whether or not the attempt to run in parallel was rejected. Would you prefer that I change it to that?

mmusgrov commented 5 years ago

No need to make any changes to the PR, it was just a query and you have answered it, thanks.