search

eclipse / microprofile-context-propagation

Apache License 2.0
33 stars 23 forks source link

CDIContextTest should allow for inactive contexts, split the tests. #171

Closed manovotn closed 5 years ago

manovotn commented 5 years ago

Fixes #170

I split the test and replaced any direct injection with dynamic resolution to avoid trying to inject beans from inactive contexts. Every test now checks if context is active and should it get negative answer, it successfully ends.

As for the change in mp_checkstyle_rules.xml - I am fine reverting that if you ask for it, but if you wouldn't mind removing it, I think it's a bit overzealous rule. This is probably the sole project where I am seeing this right curly limitations and checkstyle is giving me hell every time :)

manovotn commented 5 years ago

@kenfinnigan @mkouba just an FYI