search

eclipse / microprofile-context-propagation

Apache License 2.0
33 stars 23 forks source link

Initial proposal for #173: Adding context to existing CS/CF instances #196

Closed FroMage closed 4 years ago

FroMage commented 4 years ago

Well spotted, I've corrected them, let me know if that's fine.

manovotn commented 4 years ago

@FroMage CI complains about unused import: 04:16:15 [ERROR] /home/jenkins/agent/workspace/microprofile-concurrency-prs/api/src/main/java/org/eclipse/microprofile/context/ManagedExecutor.java:28:8: Unused import - org.eclipse.microprofile.context.spi.ContextManager. [UnusedImports]

FroMage commented 4 years ago

But it's used by javadoc, that's wrong…

FroMage commented 4 years ago

Upgraded checkstyle to a version which understands javadoc wrt. unused imports.

FroMage commented 4 years ago

Except now I don't get why CI won't run the build :-/

FroMage commented 4 years ago

Ah, CI passed now. Shall I merge this then, or should I add TCK tests first?

njr-11 commented 4 years ago

Ah, CI passed now. Shall I merge this then, or should I add TCK tests first?

Adding TCK tests in a separate pull is fine if you want to merge this first