Contextualise CF tck - Githubissues

FroMage commented 4 years ago

This is the TCK part of #173 whose code PR was merged.

I've added tests for the following things:

ManagedExecutor.copy(CF/CS) will propagate contexts
ManagedExecutor.getThreadContext() will return an instance with the same propagation settings as the ManagedExecutor
ManagedExecutor.newIncompleteFuture() (hoping all other methods behave the same, I didn't think it was worth testing them all, should I?) will respect the new ContextManager.Builder.withDefaultExecutorService()
ThreadContext.withContextPropagation(CF/CS) will respect the new ContextManager.Builder.withDefaultExecutorService(), and ban Async methods with no executor if not set, and allow them if set

Did I forget something?

FroMage commented 4 years ago

Shall I merge it then?

njr-11 commented 4 years ago

Shall I merge it then?

It all looks good to me and I'm in favor of merging. It looks like you also have @manovotn listed as a reviewer.

FroMage commented 4 years ago

We can wait for @manovotn

FroMage commented 4 years ago

Thanks.

eclipse / microprofile-context-propagation