Work with MicroProfile Telemetry Metrics

eclipse / microprofile-fault-tolerance

microprofile fault tolerance

Apache License 2.0

123 stars 63 forks source link

Work with MicroProfile Telemetry Metrics #622

Open Emily-Jiang opened 4 months ago

Emily-Jiang commented 4 months ago

Description

As a:

[ ] API User (application developer)
[ ] Specification Implementer

...I need to be able to:

get OpenTelemetry metrics

...which enables me to:

get unified metrics

benjamin-confino commented 3 months ago

I did an experiment in OpenLiberty and was able to modify our integration layer between mpFaultTolerence and mpMetrics to use telemetry metrics with minimal changes. I think we can resolve this issue without changing the fault tolerance code.

Tasks that must be acomplished:

[x] Add a section to the fault tolerence specifications covering FT and telemetry integration.
[x] Add a package to the TCK to test FT and telemetry integration.

Discussion points

[ ] Do we want to add or modify the metrics Fault Tolerence records?
[ ] What happens if both MP Telemetry and MP Metrics are enabled for the first time?

benjamin-confino commented 2 months ago

https://github.com/eclipse/microprofile-fault-tolerance/pull/623 Resolves this tasks that must be accomplished. There is still the discussion points.

Azquelt commented 2 months ago

Do we need/want a new config option to allow the export of metrics to telemetry to be disabled? (like https://download.eclipse.org/microprofile/microprofile-fault-tolerance-4.0.2/microprofile-fault-tolerance-spec-4.0.2.html#_configuring_metrics_integration)

benjamin-confino commented 2 months ago

I think if that option was useful for MP Metrics it will be useful for MP Telemetry. For simplicity I would suggest we use the same property for both, and update the spec to say it covers both.

Azquelt commented 1 week ago

Is this issue complete?