search

eclipse / microprofile-health

microprofile-health
Apache License 2.0
108 stars 61 forks source link

typo fix #258

Closed rosiecki closed 4 years ago

xstefank commented 4 years ago

Thanks for catching this. But we can't merge PRs with commits which aren't signed - https://www.eclipse.org/legal/ECA.php. Let me know if you'll need any help with that.

pgunapal commented 4 years ago

@xstefank This change was part of the PR (https://github.com/eclipse/microprofile-health/pull/257) that was merged to rename the State method to Status, to maintain consistency in HealthCheckResponseBuilder (https://github.com/eclipse/microprofile-health/blob/master/api/src/main/java/org/eclipse/microprofile/health/HealthCheckResponseBuilder.java) class for the 3.0 release. Is that still the intended approach, we are aiming for?

xstefank commented 4 years ago

@pgunapal ah, that's just me reviewing 10:45 pm :) I missed that it's other way around. Thanks for the heads up.

@rosiecki as mentioned this was an intentional change so I will close this PR. Feel free to reopen/discuss.