search

eclipse / microprofile-health

microprofile-health
Apache License 2.0
106 stars 61 forks source link

Changing the visibility of TCKBase and DeploymentUtils methods, for reuse in subclasses (e.g.: additional vendor tests) #328

Closed fabiobrz closed 5 months ago

fabiobrz commented 6 months ago

Initially related to #327

Update: This no longer fix the above linked issue, which will be most likely closed.

The reason is that it is not advisable to alter the process for TCK users, by adding one more surefire execution for testing the way a a MP Config property is set, being it passed via a system property, an environment variable, or a microprofile-config.properties file.

Instead, this PR is proposing a change to the visibility of some TCKBase methods, so that an additional test in the integration codebase could use them. The same applies to the only change to the DeploymentUtils class.

FYI @xstefank

fabiobrz commented 5 months ago

Actually the changes proposed here might not be desired since implementors would usually develop integration tests according to their execution environment rather than extending the TCKs.

WDYT @xstefank ?