search

eclipse / microprofile-lra

microprofile-lra
Apache License 2.0
101 stars 30 forks source link

issue190 Add a recovery test for Compensate and AfterLRA annotations #240

Closed xstefank closed 5 years ago

xstefank commented 5 years ago

Signed-off-by: xstefank xstefank122@gmail.com

resolves #190

mmusgrov commented 5 years ago

I cannot find a test that validates that it is possible to register for an AfterLRA notification when the LRA is already cancelling or closing. This requirement is implicit in the spec but it is probably best to add a sentence that makes it explicit. This behaviour is required since the cancellation or closure of an LRA can take an indefinite amount of time. In contrast, note that it would never make sense to allow participants to register after the end phase has begun.

xstefank commented 5 years ago

@mmusgrov since that scenario doesn't require a restart of the service, do you mind if I move it to a new issue?

mmusgrov commented 5 years ago

Not at all

On Mon, Oct 7, 2019 at 4:12 PM Martin Stefanko notifications@github.com wrote:

@mmusgrov https://github.com/mmusgrov since that scenario doesn't require a restart of the service, do you mind if I move it to a new issue?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/eclipse/microprofile-lra/pull/240?email_source=notifications&email_token=AADYPNDALYYJRN7I2ED4ZHTQNNGXBA5CNFSM4I6BDDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAQWQDY#issuecomment-539060239, or mute the thread https://github.com/notifications/unsubscribe-auth/AADYPNA6253VMC7GXDZP3GTQNNGXBANCNFSM4I6BDDJQ .

-- Michael Musgrove mmusgrov@redhat.com

JBoss, by Red Hat Registered Address: Red Hat Ltd, 6700 Cork Airport Business Park, Kinsale Road, Co. Cork. Registered in the Companies Registration Office, Parnell House, 14 Parnell Square, Dublin 1, Ireland, No.304873 Directors:Michael Cunningham (USA), Vicky Wiseman (USA), Michael O'Neill, Keith Phelan, Matt Parson (USA)

xstefank commented 5 years ago

the mentioned scenario moved to #241. This PR is ready for review.

xstefank commented 5 years ago

@mmusgrov ready for review again.

mmusgrov commented 5 years ago

The way we discuss isn't efficient, useful and possibly some issues aren't properly covered.

I agree but the tool isn't the best. Do we have suggestions on how to improve it?

Anyway, I'm just approving this since I can't remove myself as reviewer.

You are allowed to abstain. Before you joined the team we asked the broader community for permission to merge PRs.