eclipse / microprofile-lra

microprofile-lra
Apache License 2.0
101 stars 30 forks source link

#275 Fix tests that wrongly assume callbacks are delivered with "exac… #282

Closed xstefank closed 4 years ago

xstefank commented 4 years ago

…tly once" semantics

resolves #275

Changes:

Signed-off-by: xstefank xstefank122@gmail.com

xstefank commented 4 years ago

@ochaloup the answer is already in the PR description - Complete/Compensate to "at least once" where there is no Status method in the resource -- all of the tests that you mentioned invoke resources which have a Status method.

ochaloup commented 4 years ago

@xstefank oh... I see. Thanks!

xstefank commented 4 years ago

@mmusgrov This PR has two approvals so I will merge it later today. This is just a notification in case you would still like to take a look.

xstefank commented 4 years ago

@mmusgrov added a comment and a message to the test that requires only a single complete/compensate call.