search

eclipse / microprofile-lra

microprofile-lra
Apache License 2.0
101 stars 30 forks source link

Updated to the path for the LRA.java #288

Closed tomjenkinson closed 4 years ago

xstefank commented 4 years ago

@tomjenkinson Thanks, nice catch. You need to sign the ECA (link is in the failed check) otherwise we can't merge the PR.

tomjenkinson commented 4 years ago

I think it might be that as I used the UI the commit is not signed off

tomjenkinson commented 4 years ago

Commit is signed now

tomjenkinson commented 4 years ago

BTW, I used #40 for the line number as that drops into the Javadoc, I am not sure if #30 as it currently is would have gone to the same place

xstefank commented 4 years ago

Thanks @tomjenkinson. I agree the line 40 is better. I will leave this open for other reviews for a while. I will merge this later today.

tomjenkinson commented 4 years ago

I wonder how the release process will deal with links to master, perhaps whatever happens when an versioned tag is created should make sure these links to master in the spec are also modified?

xstefank commented 4 years ago

Not sure if we can automate this. We should always make sure that the links in the specification document are changed when the API classes change. I will try to remember this when reviewing PRs.