search

eclipse / microprofile-lra

microprofile-lra
Apache License 2.0
99 stars 30 forks source link

Fix a few mistakes in the specification #353

Closed xstefank closed 2 years ago

xstefank commented 3 years ago

Fixes #352

I think this should be fixed before we fork jakarta branch.

mmusgrov commented 3 years ago

@xstefank I missed some more examples of this:

./src/main/java/org/eclipse/microprofile/lra/tck/participant/nonjaxrs/InvalidAfterLRASignatureListener.java ./src/main/java/org/eclipse/microprofile/lra/tck/participant/nonjaxrs/InvalidArgumentTypesParticipant.java ./src/main/java/org/eclipse/microprofile/lra/tck/participant/nonjaxrs/InvalidReturnTypeParticipant.java ./src/main/java/org/eclipse/microprofile/lra/tck/participant/nonjaxrs/TooManyArgsParticipant.java

and in the spec directory:

[mmusgrov@dev2 microprofile-lra] (master) $ find spec -type f -exec grep  "@LRA(LRA" {} \;
    @LRA(LRA.Type.REQUIRES_NEW)
  @LRA(LRA.Type.MANDATORY, // requires an active context before method can be executed
    @LRA(LRA.Type.NESTED, end = true)
xstefank commented 3 years ago

@mmusgrov I think I got everything. If there is only one argument the value = can be omitted. Java files wouldn't compile and the one remaining spec reference seems ok to me (line 486).

mmusgrov commented 2 years ago

@xstefank you are correct. Thanks for providing a patch. Since the change is straight forward I would argue that we can merge without a review from @rdebusscher