search

eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

NamedMetadata annotation #458

Closed jmartisk closed 4 years ago

jmartisk commented 5 years ago

Early look into the @NamedMetadata addition so that I don't risk doing a lot of work on this by myself that would later be rejected. :) @pilhuhn @Channyboy @donbourne please look if this makes sense to you or it's a pure nonsense. Surely this needs more polishing, TCK tests, JavaDoc comments, etc.

donbourne commented 5 years ago

changes look good so far. how should we handle the case of someone using the MetricRegistry calls to create a metric that has the same name as was used by @NamedMetadata? Is that allowed?

jmartisk commented 5 years ago

how should we handle the case of someone using the MetricRegistry calls to create a metric that has the same name as was used by @NamedMetadata? Is that allowed?

If they provide an appropriate Metadata object with the registration, I see no reason to disallow that

jmartisk commented 4 years ago

I'd say the basic work looks done, so marking this as ready for review