eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Wrong usage of MP Config in GlobalTagsTest #488

Closed jmartisk closed 4 years ago

jmartisk commented 4 years ago

GlobalTagsTest needs to use a different Config instance than other tests, but does that in a way that it just registers the new config for the TCCL (https://github.com/eclipse/microprofile-metrics/blob/2.2/tck/api/src/main/java/org/eclipse/microprofile/metrics/tck/tags/GlobalTagsTest.java#L108). This is against the MP Config specification, because when a Config is already registered, calling registerConfig should throw an IllegalStateException. This was revealed through https://github.com/smallrye/smallrye-metrics/issues/205 after SmallRye Config was updated so that it now indeed throws this exception