search

eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Introduce optional base metrics from RESTful stats #497

Closed Channyboy closed 4 years ago

Channyboy commented 4 years ago

Current mpConfig key is mp.metrics.enable.restful.stats or could use mp.metrics.collect.restful.stats? or any other suggestions else?

Signed-off-by: David Chan chdavid@ca.ibm.com

jmartisk commented 4 years ago

About the name: should we use the term RESTful? We should decide whether this will be tied to JAX-RS in particular (in which case I would rather use JAX-RS for the naming), or it can be applied to any RESTful framework (like Spring Web).

Channyboy commented 4 years ago

@jmartisk REST metrics has been further tuned to not be optional. It is mandatory when rest/jaxrs is used. But whether it is available by default or needs to be configured to be enabled is up to the implementation.

I'm not sure if that was also what you had in mind before or if you thought REST metrics was fully optional. As are result, there is less wording in the spec.

Channyboy commented 4 years ago

@jmartisk fixed!