MP Metrics TCK improvement - Use WebArchive for deployment

eclipse / microprofile-metrics

microprofile-metrics

Apache License 2.0

100 stars 66 forks source link

MP Metrics TCK improvement - Use WebArchive for deployment #528

Closed jmesnil closed 4 years ago

jmesnil commented 4 years ago

Replace calls to addAsManifestResource by addAsWebInfResource as deployments are now WebArchives.

Signed-off-by: Jeff Mesnil jmesnil@gmail.com

jmesnil commented 4 years ago

While testing MP Metrics 2.3-RC1 on WildFly, these 2 tests were failing because the MetricsRegistry was not properly injected. Adding the empty beans.xml to WEB-INF for the web archive deployments fixed the issue.

jmartisk commented 4 years ago

@Channyboy Do you want to give it a test run? I suppose it will work, but just to be sure.