eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Need to specify how mapped and unmapped JAX-RS exceptions should be tracked #533

Closed donbourne closed 4 years ago

donbourne commented 4 years ago

The MP metrics 2.3 spec describes the use of SimpleTimer for JAX-RS requests, but does not specify exactly how mapped and unmapped exceptions should be counted.

Given the timing of requests can be significantly affected by exceptions occurring it seems we need to label metrics from exception paths differently than "clean path" executions.

Since JAX-RS programming model doesn't give us a way to tell if exceptions have occurred (and were handled), we perhaps may want to just add a label to our SimpleTimer to indicate the HTTP response code.

jmartisk commented 4 years ago

Fixed by https://github.com/eclipse/microprofile-metrics/pull/585