search

eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Upgrading rest-assured to 4.3.0 #565

Closed lamkavan closed 4 years ago

lamkavan commented 4 years ago

In relation to https://github.com/OpenLiberty/open-liberty/issues/11537

eclipse-microprofile-bot commented 4 years ago

Can one of the admins verify this patch?

jmartisk commented 4 years ago

ok to test

jmartisk commented 4 years ago

This does not seem to help on SmallRye side, I am still getting the same errors as without this fix:

[ERROR] org.eclipse.microprofile.metrics.test.MpMetricTest  Time elapsed: 4.959 s  <<< ERROR!
java.lang.NoClassDefFoundError: Could not initialize class io.restassured.RestAssured
    at org.eclipse.microprofile.metrics.test.MpMetricTest.setup(MpMetricTest.java:132)
[ERROR] org.eclipse.microprofile.metrics.test.ReusableMetricsTest  Time elapsed: 18.903 s  <<< ERROR!
java.lang.NoClassDefFoundError: Could not initialize class org.codehaus.groovy.reflection.ReflectionCache
    at org.eclipse.microprofile.metrics.test.ReusableMetricsTest.setup(ReusableMetricsTest.java:84)

And I also see

java.lang.NoClassDefFoundError: Could not initialize class org.codehaus.groovy.vmplugin.v7.Java7
    at org.codehaus.groovy.vmplugin.VMPluginFactory.<clinit>(VMPluginFactory.java:43)
    at org.codehaus.groovy.reflection.GroovyClassValueFactory.<clinit>(GroovyClassValueFactory.java:35)
    at org.codehaus.groovy.reflection.ClassInfo.<clinit>(ClassInfo.java:107)
    at org.codehaus.groovy.reflection.ReflectionCache.getCachedClass(ReflectionCache.java:95)
    at org.codehaus.groovy.reflection.ReflectionCache.<clinit>(ReflectionCache.java:39)
    at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.registerMethods(MetaClassRegistryImpl.java:209)
    at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.<init>(MetaClassRegistryImpl.java:107)
    at org.codehaus.groovy.runtime.metaclass.MetaClassRegistryImpl.<init>(MetaClassRegistryImpl.java:85)
    at groovy.lang.GroovySystem.<clinit>(GroovySystem.java:36)
    at org.codehaus.groovy.runtime.InvokerHelper.<clinit>(InvokerHelper.java:86)
    at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.createMap(ScriptBytecodeAdapter.java:635)
    at io.restassured.internal.ResponseParserRegistrar.<init>(ResponseParserRegistrar.groovy)
    at io.restassured.RestAssured.<clinit>(RestAssured.java:347)
    at org.eclipse.microprofile.metrics.test.ReusableMetricsTest.setup(ReusableMetricsTest.java:84)

It seems that we will need (at least) also a RestAssured update to work with JDK 14. Does including transitive dependencies explicitly actually solve anything for you? I can't quite imagine how that could help.

jmartisk commented 4 years ago

I think that what we need instead is updating to rest-assured 4.3.0. That fixes the TCK for me.

lamkavan commented 4 years ago

@jmartisk I was doing some testing and playing around with the transitive dependencies (saw that it fixed similar issues). Anyhow, I agree that its hard to believe/unreasonable that adding transitive dependencies would fix anything here. I'll go ahead and update the PR to upgrade rest-assured to 4.3.0

lamkavan commented 4 years ago

@jmartisk Hey I don't have write access. I was wondering if you could merge the PR for me. Thanks!

jmartisk commented 4 years ago

Sure! Thanks!