search

eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Remove text about deriving _app tag from context root #599

Closed donbourne closed 4 years ago

donbourne commented 4 years ago

The current description in the spec indicates that apps should handle population of the _app tag automatically based on the context root of the web app to which the metric belongs. In practice we're not aware of anyone who has implemented this, and it may give the impression by the presence in the spec that this is typical of app servers. Removing this makes the official way to set the _app tag be just through MP Config.

Also removed the paragraph telling multi-app server vendors that there should be a single MetricRegistry instance shared between all apps. In practice multi-app server vendors have successfully implemented this in both per-app registries and by using one registry for all app's metrics. So this guidance seems unnecessary.

Signed-off-by: Don Bourne dbourne@ca.ibm.com

jmartisk commented 4 years ago

text looks good to me, except the legal check robot is complaining, it seems that your commit contains the address donbourne@Dons-MacBook-Pro.local

donbourne commented 4 years ago

text looks good to me, except the legal check robot is complaining, it seems that your commit contains the address donbourne@Dons-MacBook-Pro.local

oops. I've amended my commit and re-pushed...