search

eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Jakarta EE 9.1 alignment #640

Closed ederks85 closed 3 years ago

ederks85 commented 3 years ago
eclipse-microprofile-bot commented 3 years ago

Can one of the admins verify this patch?

ederks85 commented 3 years ago

@Emily-Jiang I have processed your comments and also verified the generation of the spec HTML and PDF with the preferred names

Emily-Jiang commented 3 years ago

@jmartisk The formatting changes is part of consuming parent pom. Sadly, we can't separate it out.

jmartisk commented 3 years ago

But we should commit all the changes that it performs, so that after somebody clones the repo and runs a build, they don't unexpectedly receive a heap of changes in the source files.

Emily-Jiang commented 3 years ago

@jmartisk we discussed the file format issue on MP technical hangout and we agreed that we really need to unify the file format in MP. We have to update the file format some time. The concensus is that now is the good time to do so. I appreciate your concerns.

Emily-Jiang commented 3 years ago

@ederks85 I have cherry picked your commit and fixed all of the comments I had. This PR was superceded by #642