eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Open Liberty 21.0.0.12-beta: MicroProfile Metrics 4.0 Compatible Certification Request #651

Closed Emily-Jiang closed 2 years ago

Emily-Jiang commented 2 years ago
kwsutter commented 2 years ago

Same comments as on the Config 3.0 CCR -- The specification reference on the TCK Results was a non-final version, and specific java product and version should be specified. Nothing major. Thanks!

Emily-Jiang commented 2 years ago

@kwsutter this is a chicken egg situation if we produce a CCR with final spec. There was a lengthy conversation on the googlegroup discussion and we settled on using the latest RC for CCR and then stage the final version for ballot.

Emily-Jiang commented 2 years ago

There is no requirement to specify the jdk details except the version. We have been doing this since MicroPorfile 4.0.

kwsutter commented 2 years ago

@kwsutter this is a chicken egg situation if we produce a CCR with final spec. There was a lengthy conversation on the googlegroup discussion and we settled on using the latest RC for CCR and then stage the final version for ballot.

Sure, I understand the situation. But, the CCR is for the final spec. If it was me, I would list both URLs. You could reference the latest RC version and that one would exist. And, then you could also include the expected final spec url (maybe with a parenthetical explaining that this url will eventually work).

kwsutter commented 2 years ago

There is no requirement to specify the jdk details except the version. We have been doing this since MicroProfile 4.0.

One of the ideas behind the CCR is to explain how you received the results you did. If you were ever challenged on this CCR sometime down the road, you would want to know the specific product version of the Java runtime. Maybe it's not specified as a requirement, but I would think it could be helpful and informative.

Emily-Jiang commented 2 years ago

Added the link to the final version of the MicroProfile Metrics 4.0. Will take aboard your comments re. jdk details in the future CCRs.