eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Make the TCK tests CDI 4 compatible #665

Open manovotn opened 2 years ago

manovotn commented 2 years ago

As you might know, CDI 5 (EE 10) will bring some breaking changes one of which is the change of discovery mode in case of empty beans.xml. The original tracking issue can be seen at https://github.com/eclipse-ee4j/cdi/issues/500

The change is that such bean archive will now use annotated discovery mode and CDI container will only pick up beans with bean defining annotations. Previously, all classes were picked up and processes, so this mostly affects classes that had no CDI annotation but were expected to become beans.

This change affects the TCKs in this project.

Note that this can be fixed rather easily and in a compatible manner so that the TCKs will keep working in the current version (CDI 3) as well as with the updated version (CDI 4) with no further changes needed once the migration hits.

I have some WIP on my branch and will submit a PR once I have it verified against an impl (using SR impl with updated Weld 5 container).