search

eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Make sure TCKs are CDI-version agnostic #666

Open manovotn opened 2 years ago

manovotn commented 2 years ago

Fixes #665

These were the tests that started failing for me once I tried with CDI 4 (or rather the beans used in them). The rest works just fine as-is, so I didn't touch it.

To reiterate myself - this doesn't change the TCK behavior in any way. It simply makes it CDI-version agnostic so that the TCK works with CDI 3 and CDI 4 implementations. It will ease transition for any early adopters and will eliminate future fraction when actual migration to EE 10 happens. See linked issue for more information.

This change was tested with SR impl customized to run the TCKs on Weld 5 container and the tests passed.

Note that I looked into tck/api and tck/rest and tested those. The tck/optional I only scanned but didn't manage to test but there is basically two tests and all the beans are annotated so that should work just fine gong forward.

eclipse-microprofile-bot commented 2 years ago

Can one of the admins verify this patch?

manovotn commented 2 years ago

Is there no CI on this repo? Probably wouldn't hurt to add a simple one like MP reactive messaging has - https://github.com/eclipse/microprofile-reactive-messaging/blob/master/.github/workflows/build.yml