search

eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Need to include a meter registry short name in our config property names #731

Closed donbourne closed 1 year ago

donbourne commented 1 year ago

I think our config property names need to be more specific. right now we prepend "mp.metrics." to whatever the meter registry property name is. Graphite, as an example, asks for "host" and "port". So we end up with...

mp.metrics.host = ...
mp.metrics.port= ...

... that would be fine if you only support having one meter registry installed at a time, but if you have more than one you need the meter registry name in the prefix. For example, we could have...

mp.metrics.graphite.host=...
mp.metrics.graphite.port=...
donbourne commented 1 year ago

@jgallimore , WDYT on this one? is the extra short name needed?

donbourne commented 1 year ago

looks like this already exists in the spec. not sure how I missed that before!