eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Add JPMS module-info.java #771

Open kurtostfeld opened 1 year ago

kurtostfeld commented 1 year ago

The newest version 5.0.0 of microprofile-metrics-api doesn't include a module-info.java descriptor, so it's not a proper JPMS module. I see that the published jar uses bytecode version 55.0 (Java 11), so the project doesn't support older versions of Java, so adding a module-info.java should be very simple

jlink packaging, and the Maven jlink plugin in particular, requires all transitive dependencies have module-info.java descriptors, so if I add microprofile-metrics-api to my projects, I get the jlink error:

[ERROR] Error: automatic module cannot be used with jlink: microprofile.metrics.api from file:///Users/admin/.m2/repository/org/eclipse/microprofile/metrics/microprofile-metrics-api/5.0.0/microprofile-metrics-api-5.0.0.jar