search

eclipse / microprofile-metrics

microprofile-metrics
Apache License 2.0
100 stars 66 forks source link

Fix optional Base Metrics TCK test where `gc.time` is checked as a counter when it should be gauge. #786

Closed Channyboy closed 5 months ago

Channyboy commented 10 months ago

The MP Metrics 5.x TCK optional base metrics TCK at https://github.com/eclipse/microprofile-metrics/blob/main/tck/optional/src/main/java/org/eclipse/microprofile/metrics/test/optional/MPMetricBaseMetricsTest.java#L315 is checking gc.time as a counter with an appending _total. The gc.time is a gauge.

The test is checking for gc_time_seconds_total when it should be gc_time_seconds.

Channyboy commented 5 months ago

5.0.2 -> https://github.com/eclipse/microprofile-metrics/pull/788 5.1.1 -> https://github.com/eclipse/microprofile-metrics/pull/787