search

eclipse / microprofile-open-api

Microprofile open api
Apache License 2.0
131 stars 82 forks source link

Unit Test: @SchemaProperty overrides implementation class attributes #465

Closed scottcurtis2605 closed 3 years ago

scottcurtis2605 commented 3 years ago

Created in response to a suggestion from @MikeEdgar within the following issue rasied within the SmallRye OpenAPI repository.

This PR adds an additional test to the tck, which verifies that the @SchemaProperty annotation overrides implementation class attributes, validating the behaviour for this annotation within the specification.

Created a separate PR, as was having issues with singing during the previous PR attempt.

scottcurtis2605 commented 3 years ago

Not too sure why the ECA is still failing when it has been signed. I've also ensured my git, github, eclipse accounts and PGP signature are all using the same email address. Git has also been configured to sign all commits with my PGP key, too. I am also committing with git commit -S -m "etc.".

Emily-Jiang commented 3 years ago

@scottcurtis2605 You need to create an issue first and then create a PR. I suggest you start from scratch and then just create one commit to ensure you sign off properly.