search

eclipse / microprofile-open-api

Microprofile open api
Apache License 2.0
131 stars 82 forks source link

<fix>(417): Changed applicable context for ApiResponse and ApiResponses annotations #478

Closed Name-not-available closed 2 years ago

Name-not-available commented 3 years ago

I really want this to be done in order to highly decrease amount of boilerplate in my project.

Fixes #417.

Thank you.

eclipse-microprofile-bot commented 3 years ago

Can one of the admins verify this patch?

Name-not-available commented 3 years ago

Will this be merged after legal agreement signment?

Emily-Jiang commented 3 years ago

Will this be merged after legal agreement signment?

TCKs for this need to be added as well.

MikeEdgar commented 2 years ago

@Name-not-available are you interested in picking this back up? I think it might be good to limit this change to just adding ElementType.TYPE. We could revisit adding ElementType.ANNOTATION_TYPE in the future when that can be added consistently to any other annotations necessary in this project.

If you'd like to work this one, please take a look at updating the TCK so that (1) at least one of the test resources has an @APIResponse at the class level and (2) the tests are updated to check that the response is applied to the operations contained in the resource class. Of course you'll need to complete the necessary legal agreement as well.

MikeEdgar commented 2 years ago

Replaced by #524