search

eclipse / microprofile-open-api

Microprofile open api
Apache License 2.0
131 stars 82 forks source link

Use fixed assertions #495

Closed tevans78 closed 2 years ago

tevans78 commented 2 years ago

Signed-off-by: tevans tevans@uk.ibm.com

assertSame and assertNotSame are broken in TestNG 7.4.0 - https://github.com/cbeust/testng/issues/2486 This PR adds the same methods, but instead re-implemented using Hamcrest Matchers Should be removed when TestNG 7.5.0 is released

fixes #494

eclipse-microprofile-bot commented 2 years ago

Can one of the admins verify this patch?

MikeEdgar commented 2 years ago

@Emily-Jiang - is this needed for the jakarta branch?

Emily-Jiang commented 2 years ago

@Emily-Jiang - is this needed for the jakarta branch?

@MikeEdgar yes. I'll merge in and do another RC :)

Emily-Jiang commented 2 years ago

Thank you @MikeEdgar for your timely review!