search

eclipse / microprofile-open-api

Microprofile open api
Apache License 2.0
131 stars 81 forks source link

Code formatting rules are unsuitable #518

Closed Azquelt closed 1 year ago

Azquelt commented 2 years ago

The formatting rules that are currently used on this project make the code completely unreadable. See this line for an example: JAXRSApp.java#L66.

I think the major problem is that line breaks aren't allowed after a comma separating annotation parameters.

I realise the formatting rules are inherited from the parent microprofile project, but can we either get the parent copy updated or tweak them for this project which by design allows for very large annotations?

MikeEdgar commented 1 year ago

@Azquelt, I think we can consider this done with #537. Do you agree or do you think there's room for further improvement?

Azquelt commented 1 year ago

Good point, yes I think the formatting rules are ok now. We can close this but you've reminded me that I meant to open an issue to push the changes upstream.