search

eclipse / microprofile-open-api

Microprofile open api
Apache License 2.0
131 stars 81 forks source link

Update parent, add module-info, streamline OSGi annotation dependency #577

Closed MikeEdgar closed 5 months ago

MikeEdgar commented 6 months ago

Update parent, add module-info, streamline OSGi annotation dependency. Removes dependency on the biz.aQute.bnd artifact as the osgi.annotation should be the only one necessary.

Fixes #573

I will also submit a follow-up PR with the changes for #574 once this is merged.

Azquelt commented 5 months ago

You've left this in draft, was there anything you still wanted to change before it's merged?

MikeEdgar commented 5 months ago

No, nothing additional to change.

Emily-Jiang commented 3 months ago

You should use the mp-parent 2.x not 3.x as 3.x will pull in Jakarta EE 10 api but this spec does not use any Jakarta EE 10 new APIs. Therefore, it should be built with Jakarta EE 9.1.

MikeEdgar commented 3 months ago

@Emily-Jiang are we able to set the compiler release to 11 since 2.x is still using 1.8? Otherwise we will need to remove the module-info and possibly revert the OSGi dependency changes.

Emily-Jiang commented 3 months ago

@Emily-Jiang are we able to set the compiler release to 11 since 2.x is still using 1.8? Otherwise we will need to remove the module-info and possibly revert the OSGi dependency changes.

yes, you can override it to be 11 in your own pom.xml

Azquelt commented 1 week ago

The module-info appears to cause some trouble building the aggregated javadoc: eclipse/microprofile#443

I'm looking into it, but if anyone has any ideas I'd appreciate it.