eclipse / microprofile-opentracing

microprofile-opentracing
Apache License 2.0
56 stars 47 forks source link

SmallRye: Compatible Certification Request for MicroProfile OpenTracing 2.0 #214

Open xstefank opened 3 years ago

xstefank commented 3 years ago
kwsutter commented 3 years ago

The Specification Name and Version item should point at the actual Spec. I would put a reference to the eventual maven repo: https://search.maven.org/artifact/org.eclipse.microprofile.opentracing/microprofile-opentracing-spec/2.0

Same thing for the Compatible Impl. Reference the maven artifact: https://search.maven.org/artifact/io.smallrye/smallrye-opentracing/2.0.0-RC1/jar

xstefank commented 3 years ago

@kwsutter updated.

Emily-Jiang commented 3 years ago

The Specification Name and Version item should point at the actual Spec. I would put a reference to the eventual maven repo: https://search.maven.org/artifact/org.eclipse.microprofile.opentracing/microprofile-opentracing-spec/2.0

@kwsutter This depends on the purpose of this CCR. If we put the unexisting repo as your specified, people won't be able to click the link to verify. This might have defeated the purpose of this CCR. CCR is not the certification proof from my understanding. It is the evidence to prove we can pass all TCKs so we can release the artificates. With what your suggestions, it is like you want this issue hangs around after the release. I think all links should be clickable. I think the link to the relevant repo release tag is the permanent link and it always works even after the push to maven central happens (e.g. https://github.com/eclipse/microprofile-config/releases/tag/2.0)

Same thing for the Compatible Impl. Reference the maven artifact: https://search.maven.org/artifact/io.smallrye/smallrye-opentracing/2.0.0-RC1/jar

kwsutter commented 3 years ago

@Emily-Jiang See my response in the other CCR with the same comment: https://github.com/eclipse/microprofile-fault-tolerance/issues/586#issuecomment-747498547

dblevins commented 3 years ago

Similar feedback as @kwsutter. See my same comment on this CCR https://github.com/eclipse/microprofile-open-api/issues/459#issuecomment-748362004