search

eclipse / microprofile-parent

Apache License 2.0
2 stars 19 forks source link

Update Parent POM with common build requirements for all MP projects. #34

Closed radcortez closed 3 years ago

radcortez commented 3 years ago

This requires: https://github.com/microprofile/microprofile-build-tools

This is how it looks like applied to a MP project: https://github.com/eclipse/microprofile-config/pull/663

radcortez commented 3 years ago

/cc @ederks85 I'm unable to add you as a reviewer, don't know why. Do you have your committer access to EF yet?

ederks85 commented 3 years ago

@radcortez The changes look nice. I have started a review myself, so now I'm also a reviewer

Emily-Jiang commented 3 years ago

Did you look at the API and TCK pom.xml as well as the parent pom.xml, as the other pom.xml have more dependencies and plugins specified?

radcortez commented 3 years ago

Did you look at the API and TCK pom.xml as well as the parent pom.xml, as the other pom.xml have more dependencies and plugins specified?

I've tried to come up with a minimum POM, and include only the things that we know we need to every project in the first PR. Of course, we can add more stuff later once we start to integrate the POM with each project we should start to see more pattern to move here.

Emily-Jiang commented 3 years ago

Did you look at the API and TCK pom.xml as well as the parent pom.xml, as the other pom.xml have more dependencies and plugins specified?

I've tried to come up with a minimum POM, and include only the things that we know we need to every project in the first PR. Of course, we can add more stuff later once we start to integrate the POM with each project we should start to see more pattern to move here.

@radcortez all of the specs use the bnd pluging to work out whether there are any incompatible changes or not. The plugin and dependencies are included in all specs.

radcortez commented 3 years ago

@radcortez all of the specs use the bnd pluging to work out whether there are any incompatible changes or not. The plugin and dependencies are included in all specs.

I've added the BDN stuff.