search

eclipse / microprofile-reactive-streams-operators

Microprofile project
Apache License 2.0
82 stars 33 forks source link

ServiceLoader.load() should be in a privileged action #170

Closed kabir closed 2 years ago

kabir commented 3 years ago

Without this when running with a security manager I get exceptions in WildFly

eclipse-microprofile-bot commented 3 years ago

Can one of the admins verify this patch?

Emily-Jiang commented 2 years ago

@kabir can you resolve the merge conflict?

Emily-Jiang commented 2 years ago

@cescoffier Do you foresee any issues to take this change in?

cescoffier commented 2 years ago

No, it should be fine.

Emily-Jiang commented 2 years ago

@kabir please solve the merge conflict and then mention this change in the release note of this spec doc so that we can take this PR into the 3.0 release.

kabir commented 2 years ago

@Emily-Jiang Rebased. In the new version I switched to PrivilegedExceptionAction since the multiple provider check throws an exception which would have been swallowed with what I had originally.

I've added a release not entry. Hopefully, the location and format is acceptable.