search

eclipse / microprofile-reactive-streams-operators

Microprofile project
Apache License 2.0
79 stars 33 forks source link

Allow the ScheduledExecutorService to be provided by the container #178

Closed tevans78 closed 2 months ago

tevans78 commented 1 year ago

When running in an Jakarta EE web/full profile environment, the ScheduleExecutorService should be provided by the container.

tevans78 commented 1 year ago

@eclipse-microprofile-bot test this please

eclipse-microprofile-bot commented 1 year ago

Can one of the admins verify this patch?

tevans78 commented 1 year ago

@eclipse-microprofile-bot test this please

Azquelt commented 1 year ago

@eclipse-microprofile-bot test this please (the bot only listens to committers to prevent someone creating a malicious PR which attacks the build system when a build is run)

tevans78 commented 1 year ago

@Azquelt any idea why that build failed?

Azquelt commented 1 year ago 
[ERROR] Failed to execute goal net.revelc.code:impsort-maven-plugin:1.4.1:sort (sort-imports) on project microprofile-reactive-streams-operators-api: Execution sort-imports of goal net.revelc.code:impsort-maven-plugin:1.4.1:sort failed: A required class was missing while executing net.revelc.code:impsort-maven-plugin:1.4.1:sort: null

IIRC this is an issue with old versions of impsort-maven-plugin and newer versions of maven and we maybe need to update to a newer version of the MP Parent POM. I'll have a look tomorrow and see if I can sort it out.

Azquelt commented 1 year ago

On further investigation, it looks like we updated the versions of Maven and Java in the build in order to allow the update of the parent pom in #177.

If we get that merged, I expect this PR will then build correctly.