More work on streams images

eclipse / microprofile-reactive-streams-operators

Microprofile project

Apache License 2.0

80 stars 33 forks source link

More work on streams images #86

Closed jroper closed 6 years ago

jroper commented 6 years ago

Changed image directory configuration so that images should now render in GitHub.
Switched to using SVG instead of PNG because asciidoctor had a problem including interlaced PNGs in the PDF output.
Added some more images, and reworked the docs a little bit to be more explicit about stages vs graphs and how they compose.
Changed the shapes of stream stages to be pentagons, convex pentagons chevrons rather than rectangles to make their shapes a little clearer.

jroper commented 6 years ago

To view the finished product, view here (now GitHub can find the images so it renders nicely):

https://github.com/jroper/microprofile-reactive/blob/417c0b99478f4e5173f405d825ef7764e628f63d/streams/spec/src/main/asciidoc/architecture.asciidoc

cescoffier commented 6 years ago

I was thinking about changing the colors to reuse the MP colors. I know... purely cosmetic.

jroper commented 6 years ago

Ok, so what are MP colours? For yellow, the MP logo uses #FDB71C, while the website stylesheets use #EFC94C. The latter is used as a background colour, so we should probably use the former for lines in diagrams. The other MP colour is blue, but the website itself never uses this colour as a solid colour, the blue that you see in the website is a transparent layer on top of an image. The only solid blue I could find was in its favicon, where it uses #1F3A50. The original logo announcement blog post has a logo sporting #19405B as its blue. They're not terribly different, the latter is a bit more blue. So I'm going for the latter. So the two colours are #FDB71C and #19405B.

I've updated this PR with the images using those colours.

jroper commented 6 years ago

And the updated link for previewing the images in the documentation is:

https://github.com/jroper/microprofile-reactive/blob/19f72176178d0eeafb5f896326381d8d1059da1e/streams/spec/src/main/asciidoc/architecture.asciidoc

jroper commented 6 years ago

I've updated the colours again according to the discussion on the mailing list, a very slight (almost unnoticeable) change to the blue from #19405B to #123E5C. Here's the link to preview:

https://github.com/jroper/microprofile-reactive/blob/d52d277751ae0994eabf46151e1a0df81db073a9/streams/spec/src/main/asciidoc/architecture.asciidoc

jroper commented 6 years ago

Merging as it was decided in the Reactive Hangout to merge this.