eclipse / microprofile-rest-client

MicroProfile Rest Client
Apache License 2.0
141 stars 71 forks source link

Enable SPI/ServiceLoader under OSGi #312

Closed brevilo closed 3 years ago

brevilo commented 3 years ago

Based on the following discussion: https://github.com/eclipse/microprofile-rest-client/issues/308#issuecomment-813638983

Cheers

brevilo commented 3 years ago

@andymc12, feel free to merge my changes into a PR of your own (regarding authorship).

brevilo commented 3 years ago

Hi @andymc12, do you think this one is ready to merge now...? 😏

andymc12 commented 3 years ago

Sorry for the delay on this @brevilo - thanks again for the PR!

brevilo commented 3 years ago

Thanks! Anytime!

brevilo commented 3 years ago

BTW, how about another (RC) release? 😏 Would love to get rid of another fork...

andymc12 commented 3 years ago

@brevilo

BTW, how about another (RC) release? 😏 Would love to get rid of another fork...

Just released https://github.com/eclipse/microprofile-rest-client/releases/tag/2.0.1-RC2

brevilo commented 3 years ago

Awesome! One down, two remaining (at CXF)...

brevilo commented 3 years ago

@brevilo

BTW, how about another (RC) release? 😏 Would love to get rid of another fork...

Just released https://github.com/eclipse/microprofile-rest-client/releases/tag/2.0.1-RC2

Hm, @andymc12 can you please check that again? I don't tink it's part of that release candidate: https://github.com/eclipse/microprofile-rest-client/compare/2.0.1-RC1...2.0.1-RC2 (or any tag for that matter, just in master so far).

Thanks

andymc12 commented 3 years ago

@brevilo good catch - I must not have backported the changes to 2.0.X-service before publishing RC2. I have published RC3 now which show your latest change and mine: https://github.com/eclipse/microprofile-rest-client/compare/2.0.1-RC2...2.0.1-RC3

Here is the release page: https://github.com/eclipse/microprofile-rest-client/releases/tag/2.0.1-RC3

Thanks!

brevilo commented 3 years ago

You're welcome 👍 Thanks for the swift action - works like a charm!