search

eclipse / microprofile-rest-client

MicroProfile Rest Client
Apache License 2.0
141 stars 71 forks source link

Replace javax namespace usage with jakarta and align with Microprofile 6.0 #352

Closed reta closed 7 months ago

reta commented 1 year ago

The Microprofile 6.0 is out and aligns with Jakarta EE 10 Core Profile. It still bundles MicroProfile Rest Client 3.0 [1] but the minimum Java SE version now is Java SE 11 or higher [2]. With that in mind, we could fix the remaining javax.* -> jakarta.* by updating to Wiremock 3.0.0 (which uses Jetty 11).

Closes https://github.com/eclipse/microprofile-rest-client/issues/346

[1] https://github.com/eclipse/microprofile/releases/tag/6.0 [2] https://jakarta.ee/specifications/coreprofile/10/

michalszynkiewicz commented 1 year ago

hey @andymc12 , I'm no longer at RH

andymc12 commented 1 year ago

hey @andymc12 , I'm no longer at RH

Thanks for letting me know - and congrats on your new job! I tagged Pavol for RH's review instead.

Emily-Jiang commented 1 year ago

This spec do not need to be updated to align with Jakarta EE 10 Core Profile as it should work with Jakarta EE 9.1 or EE 10.

reta commented 1 year ago

This spec do not need to be updated to align with Jakarta EE 10 Core Profile as it should work with Jakarta EE 9.1 or EE 10.

Fair enough, the TCK seems to be stuck in own reality, due to dependency choices, and still uses javax.*. Should the TCK be rewritten then?

Emily-Jiang commented 1 year ago

This spec do not need to be updated to align with Jakarta EE 10 Core Profile as it should work with Jakarta EE 9.1 or EE 10.

Fair enough, the TCK seems to be stuck in own reality, due to dependency choices, and still uses javax.*. Should the TCK be rewritten then?

The update of Wiremock 3.0.0 (which uses Jetty 11) can be done. Many runtimes certified this TCK for MP 5.0 without any issues though.

reta commented 1 year ago

This spec do not need to be updated to align with Jakarta EE 10 Core Profile as it should work with Jakarta EE 9.1 or EE 10.

Fair enough, the TCK seems to be stuck in own reality, due to dependency choices, and still uses javax.*. Should the TCK be rewritten then?

The update of Wiremock 3.0.0 (which uses Jetty 11) can be done.

Wiremock 3 / Jetty 11 needs JDK 11 (this pull request)

Many runtimes certified this TCK for MP 5.0 without any issues though.

The workarounds exist to make it work, but that is not sustainable to be fair

Emily-Jiang commented 7 months ago

360 superseded this. I will close this one.