eclipse / microprofile-rest-client

MicroProfile Rest Client
Apache License 2.0
142 stars 72 forks source link

Use the correct paths to trigger CI. #373

Closed jamezp closed 4 months ago

jamezp commented 5 months ago

Note on the second commit. For some reason the formatter-maven-plugin was not being invoked by default. It seems after #374 being merged, it started being invoked.

I did checkout a tag and apparently I'm wrong, this has been enabled the whole time. I don't know why this didn't get invoked for the #371 PR. Possibly it was out of date with main, I'm not sure.

jamezp commented 5 months ago

@jim-krueger For some unknown reason in #371, these files did not get formatted by the formatter-maven-plugin. The changes are needed so we don't see uncommitted changes every time you build the project. This will not happen in the future now that CI is actually enabled via this PR as well.

jim-krueger commented 5 months ago

Yes, I saw that too and wondered why. I'm all for not seeing them again. Thanks

jamezp commented 5 months ago

@Emily-Jiang Could we get this merged? This will fix CI to actually start jobs and avoid further compile issues.