search

eclipse / microprofile-samples

Micro Profile Samples
Apache License 2.0
118 stars 63 forks source link

Fixes #11 #12

Closed kenfinnigan closed 8 years ago

kenfinnigan commented 8 years ago

Adds a profile thats active by default that skips all surefire tests

karianna commented 8 years ago

Hmmm, do we really want the default to skip tests?

kenfinnigan commented 8 years ago

My thoughts behind this is that we're no longer running a profile, such as WildFly, as default which means the test fails and the build breaks.

Given that, I thought it was preferable that the skinny WAR of the applications could be built at a minimum with the basic mvn clean package.

If everyone's ok with the build failing without a profile for testing being set, then that's fine

karianna commented 8 years ago

I'd rather run the tests as the default. I assume the issue there is that we 'favour' one vendor over another?

kenfinnigan commented 8 years ago

Right.

Previously it was using WildFly by default but that was removed.

karianna commented 8 years ago

I'm hoping this: https://groups.google.com/forum/#!topic/microprofile/UmSBaVD_ZLk will resolve the issue long term. In the meantime I guess it's better to have running out of the box.