search

eclipse / microprofile-samples

Micro Profile Samples
Apache License 2.0
118 stars 63 forks source link

Make bean discovery all #15

Closed smillidge closed 8 years ago

smillidge commented 8 years ago

Application as it stands fails to work on Payara and GlassFish this is because TopCDsEndpoint is not considered a CDI bean therefore Logger injection fails asTopsCDsEndpoint does not have a bean defining annotation.

I've opted to make beans.xml discovery to be all. Although I could add a bean defining annotation for TopCDsEndpoint.

johnament commented 8 years ago

-1 fix the endpoint class (so that it works the way the spec describes)

https://github.com/hammock-project/microprofile-samples/blob/master/microprofile-sample-canonical/src/main/java/io/microprofile/sample/canonical/rest/TopCDsEndpoint.java#L34

smillidge commented 8 years ago

OK that was the other option