search

eclipse / microprofile-samples

Micro Profile Samples
Apache License 2.0
118 stars 63 forks source link

Added a Hammock based build for microprofile. #20

Closed johnament closed 8 years ago

johnament commented 8 years ago

Added a proper set of build profiles for Hammock.

(removed the don't merge)

kenfinnigan commented 8 years ago

There are several changes that, though might be required to make Hammock profile work, are not directly related to the presence of a Hammock profile.

Such as beans.xml and Bean scope changes. I feel these changes should be in a separate PR

johnament commented 8 years ago

@kenfinnigan can you list them out a bit more? You mentioned the JAR change, which I think I can work around.

matzew commented 8 years ago

yeah, noticed same problems on other src files.

but since code is not ASF project, I'd be surprised if that was done on intention ;)

On Saturday, 17 September 2016, John Ament notifications@github.com wrote:

@johnament commented on this pull request.

In microprofile-sample-canonical/src/main/resources/META-INF/beans.xml https://github.com/microprofile/microprofile-samples/pull/20:

@@ -0,0 +1,23 @@ +<?xml version="1.0" encoding="UTF-8" standalone="yes"?> +<!--

  • ~ Licensed to the Apache Software Foundation (ASF) under one

Hey Matthas! Long time no see!

I just asked about this on the list https://groups.google.com/forum/#!topic/microprofile/UvPWRMOtcfk, since its not consistent right now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/microprofile/microprofile-samples/pull/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJnzmhMPnKfNhyb486Lv_FHSgv1yefBks5qrDQtgaJpZM4J8q9X .

Sent from Gmail Mobile

johnament commented 8 years ago

I'm going to enable travis and make it build this PR.

matzew commented 8 years ago

:+1:

On Tuesday, 20 September 2016, John Ament notifications@github.com wrote:

I'm going to enable travis and make it build this PR.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/microprofile/microprofile-samples/pull/20#issuecomment-248379987, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJnzrX2dhE5awM7hMpgRimgblH6AVFSks5qsB4DgaJpZM4J8q9X .

Sent from Gmail Mobile

johnament commented 8 years ago

Woo build passed #winning 🎱

karianna commented 8 years ago

So it's just the licensing Q to go?

johnament commented 8 years ago

@karianna I think we know the fix for the licensing issue. But that should come next.

johnament commented 8 years ago

Ping. I'm not planning to make any more functional changes on this PR. If someone sees something missing, please shout. I can definitely raise a follow up PR to fix the license headers across the board.