search

eclipse / microprofile-samples

Micro Profile Samples
Apache License 2.0
118 stars 63 forks source link

33: Eclipse Naming conventions, 34: Correct license headers #36

Closed keilw closed 7 years ago

keilw commented 7 years ago

Task-Url: https://github.com/microprofile/microprofile-samples/issues/33, https://github.com/microprofile/microprofile-samples/issues/issues/34

keilw commented 7 years ago

The built-in Eclipse/Java formatting rules e.g. have a tab size 8. In a different thread and repo we discussed another plugin that applies Eclipse formatting rules in Maven (similar to https://github.com/unitsofmeasurement/unit-ri/blob/master/src/etc/eclipse-formatter-config.xml) but let's keep that in a separate PR and issues. Is there a problem with the way I applied Eclipse packages and correct headers?

keilw commented 7 years ago

@kwsutter @kenfinnigan You mean the shade-plugin in the "hammock" profile? I did not run or change that particular profile, maybe @johnament knows more about it, or offer PR only on that detail. I could not see a problem in the POM though, so unless you say it's better to remove it I did not do yet.

Also added a readme chapter on formatting code. Not sure, about the license header plugin, that may not be used by too many once the initial contribution was made.

keilw commented 7 years ago

If it's only the POM (those did not get automatic headers via the plugin) I'll fix it manually.

Actually I included POMs in the header generation, too. Fixed. I believe the style Antonio used may have clashed with the formatting profile ;-)