search

eclipse / microprofile-samples

Micro Profile Samples
Apache License 2.0
118 stars 63 forks source link

Add git clone command to README #46

Closed brunoborges closed 6 years ago

brunoborges commented 6 years ago

Since the README is exposed as a webpage under https://microprofile.io/project/eclipse/microprofile-samples, this helps those hitting that URL to follow all the steps without having to visit the actual GitHub repository.

mikecroft commented 6 years ago

Looks good! Have you signed the Eclipse ECA @brunoborges? Normally there should be a check to make sure that that is the case before we can merge stuff, but it doesn't seem to have shown up. Once someone can confirm the IP check is all good, then we can get this merged :+1:

brunoborges commented 6 years ago

Yes I have signed the ECA.

The Eclipse Contributor Agreement that we have on record for you will expire on 2021-03-19.

My GitHub username is configured under my Eclipse profile account. Weird that it didn't pull that info automatically.

brunoborges commented 6 years ago

@mikecroft mind to review and merge?

mikecroft commented 6 years ago

I would if I could @brunoborges - after moving to Red Hat it looks like the change to my Eclipse profile has retained my committer status, but I've been removed from the GitHub team during the process!

Maybe @OndrejM can get this merged in the mean time 🙂

mikecroft commented 6 years ago

Account all sorted - I'm back on the team!