eclipse / microprofile-samples

Micro Profile Samples
Apache License 2.0
118 stars 63 forks source link

Feature/thorntail-config-sample #51

Closed cchet closed 1 year ago

cchet commented 6 years ago

This branch is based on feature/thorntail of PR #50 and adds a microprofile-sample-config project for microprofile-config usage.

See README for available endpoints and expected configuration parameters.

I have still some little issues:

cchet commented 6 years ago

So, now I consider it done. Added additional test methods

cchet commented 6 years ago

Any feedback ?

kenfinnigan commented 6 years ago

I think it would be easier for #50 to be merged and included before considering what this PR is looking to bring.

Separate to that, are there any reasons to have a separate example rather than add Config usage into the main example?

cchet commented 6 years ago

I thought a sample project per microprofile specification is intended. There is no problem to merge the config sample with the main sample

kenfinnigan commented 6 years ago

Honestly I can't recall what the original intent of that repo was, other than a way to show an app running on all the containers

cchet commented 6 years ago

Is the repository considered to stay alive ? I thought the repository is for showing samples, how to use the different microprofile specifications in a microservice, or in particular a standalone application.

kenfinnigan commented 6 years ago

The activeness of this repository and microprofile-conference is something to be discussed in the community.

I'm not sure if the samples repo was intended to showcase every spec in a different module, as opposed to just adding to the main canonical one

cchet commented 6 years ago

Ok , but is worth to invest further work on this PR and PR #50, if its just showing an app running on multiple containers ?

kenfinnigan commented 5 years ago

Sorry for the delayed response @cchet

I'm going to be posting to the Forum soon explain some thoughts around this that may make this PR alter a bit in it's focus

cchet commented 5 years ago

No problem. Thanks for the response