search

eclipse / microprofile-sandbox

Apache License 2.0
38 stars 54 forks source link

Moved Proposal from Google Docs #22

Closed phillip-kruger closed 5 years ago

phillip-kruger commented 5 years ago

As discussed, this pull request is to move the proposal from Google Docs to GitHub, now as asciidoc files.

andymc12 commented 5 years ago

Hi @phillip-kruger - sorry, I moved the readme to asciidoc earlier this weekend, so now there is a conflict.

Also, the MP community uses a "signature" approach that adds a "Signed by: " on the commits. Can you merge your commits into 1 (rebasing after my change to avoid the conflict), and then use git commit -s to add the "Signed by" text to the commit message? The IP validation tool then checks your email address against the list of people who have signed the Eclipse licensing agreement - if you haven't done that yet, you'll need to do that too.

If you have any questions about that process, please let me know. Other than that, the changes look good. Thanks for doing this!

phillip-kruger commented 5 years ago

ok, closing this one