search

eclipse / microprofile-sandbox

Apache License 2.0
38 stars 54 forks source link

Use the simpler form for query #24

Closed thejibz closed 5 years ago

andymc12 commented 5 years ago

Hi @thejibz - Thanks for the PR. The MP community uses a "signature" approach that adds a "Signed by: " on the commits. Can you re-commit using git commit -s to add the "Signed by" text to the commit message? The IP validation tool then checks your email address against the list of people who have signed the Eclipse licensing agreement - if you haven't done that yet, you'll need to do that too.

You may be able to do this using the same PR. Thanks again! Andy

thejibz commented 5 years ago

Hello Andy, Let's forget about this PR, it was more for testing purpose. The next PR will contains the same change + all the APIs and their tests ! I will then use the -s option :) PS: Yes, I have signed the Eclipse agreement. Thanks, JB