search

eclipse / microprofile-sandbox

Apache License 2.0
38 stars 54 forks source link

API + tests + signed commit #30

Closed thejibz closed 5 years ago

thejibz commented 5 years ago

Tests only serve as a breaking change detectors (ie. no code tested beside java compiler :p).

Put a "value" field in every annotations, did best guess of the most used param.

Merged Type and FieldsOrder annotations. Merged InputType and InputFieldsOrder annotations.

Source not tested as it needs more thoughts.

thejibz commented 5 years ago

Ok, I tried everything..

Tried:

I run out of ideas... And I pollute your mailbox I think... Sorry.

andymc12 commented 5 years ago

@thejibz - hmm... something is not right here. When you do the commit -s ... in your local workspace, the commit message should include some text like this:
Signed-off-by: Andy McCright <j.andrew.mccright@gmail.com>

I don't know if it is required, but that same text usually goes in the PR too. Then the IP tooling can check that email address against the list of people who have signed the Eclipse IP agreement (ECA).

When I click the Details button, I see this:

The pull request did not pass Eclipse validation.

The following users do not have valid ECAs. Please see this page for details, or to sign a ECA.
thejibz@users.noreply.github.com

The following users have invalid Signed-off-by footers. Please use the Signed-Off-By (git commit -s) mechanism to confirm the origin of the submission. The identity in the Signed-off-By must match the Author or the Committer.
noreply@github.com
jb.roux@ymail.com

That might mean that the email address associated with your local git environment is not set up - or that it uses a different email address than you used when you signed the ECA. Also, make sure to leave the "Signed by: ..." text in your commit message and in the PR. Hope this helps, Andy

thejibz commented 5 years ago

Thank you Andy for your help ! I will try another way to create the PR. I checked my .gitconfig, it seems OK (having the right mail). I will create the PR inside GitHub instead of using GitKraken.